Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: close tabs in tab widget when main window is closed #89

Merged
merged 2 commits into from
Sep 27, 2024
Merged

BUG: close tabs in tab widget when main window is closed #89

merged 2 commits into from
Sep 27, 2024

Conversation

shilorigins
Copy link
Collaborator

@shilorigins shilorigins commented Sep 27, 2024 •
edited
Loading

Description

Fix bug where LivePVTableModel polling threads aren't cleaned up when the main window is closed.

Closes #88

Motivation and Context

See #88

How Has This Been Tested?

Interactively

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@shilorigins shilorigins self-assigned this Sep 27, 2024
tangkong
tangkong approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While (har) I like the guarantee that a for loop will terminate, this should be sufficient to get all the tabs. If the tab removal process ever somehow doesn't decrement the count, we'll only have ourselves to blame

@shilorigins shilorigins merged commit df16e55 into pcdshub:master Sep 27, 2024
11 checks passed
@shilorigins shilorigins deleted the devagr/main-window-close-children branch September 27, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangkong tangkong tangkong approved these changes

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees

@shilorigins shilorigins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: LivePVTableModel polling isn't stopped before deletion when main window is closed
3 participants
@shilorigins @ZLLentz @tangkong